-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pep8 lint #82
base: master
Are you sure you want to change the base?
Pep8 lint #82
Conversation
Thanks for this @cg-cnu. I'm getting a slightly different set of warnings here from my linter (Anaconda, Sublime 3) so I think it's a good opportunity to add linting to the automated test suite here on GitHub. I'll take a look at that within the coming days. |
@mottosso Sounds fantastic! Let me know if I can be of any help! 😄 |
Actually, if you'd like, I'd be happy for you to do that. :) It'd involve setting up Travis, running docker-maya on it, installing and running pylint on it to check for errors. It's a challenge. Let me know. :) |
Wow! Thanks for the offer 🙇 I would be happy to pickup. 😄 |
Certainly! Have a look at the Qt.py project for inspiration; I'd imagine the set-up to be quite similar. Notice that I've linked to an older commit, when the Dockerfile and Travis configuration file wasn't so complex. In a nutshell, you can start by pulling mottosso/docker-maya and get the pylint working in there. You'll need to run it via More inspiration can be found in the Avalon project, which uses the docker-maya project as well. In this Dockerfile, you can see how it builds upon docker-maya, and adds a custom command to it. In the .travis.yml file, you can see how it's being used. But you can focus on getting a Dockerfile up and running first, and having it run successfully on your local machine first. Once that's done, getting Travis to run it is really straightforward. Any questions, fire away. :) |
Fixes #81