convert-prototype-extensions doesn't work with spread operators

[stefanpenner]

the following breaks:

foo: function() {

}.property(...FILES)

because it transpiles to:

foo: Ember.computed(...FILES, function() {

})

and because spread must be the final element in a list, or method signature, bad things happen.

[abuiles]

@kamal got some time to review?

@stefanpenner maybe can you add a failing example here https://github.com/abuiles/ember-watson/blob/master/tests/fixtures/prototype-extension-files/old.js and then we'll fix it

[stefanpenner]

actually, i think this is just a bug in recast as babel handles this fine:http://babeljs.io/repl/#?experimental=true&playground=false&evaluate=true&loose=true&spec=true&code=var%20keys%20%3D%20%5B'a'%2C%20'b'%2C%20'c'%5D%3B%0A%0Avar%20a%20%3D%20%7B%0A%20%20b%3A%20Ember.computed(...Keys%2C%20function()%20%7B%0A%20%20%20%20%0A%20%20%7D)%0A%7D

I wonder if ember-watson would be better served by using the proposed transform API that lands with babel 5x (cc @sebmck, maybe you can share resources on this)

[abuiles]

Sounds like a good excuse to use Babel's transform :P

Adolfo Builes

On Mon, Mar 30, 2015 at 12:13 PM, Stefan Penner notifications@github.com
wrote:

actually, i think this is just a bug in recast as babel handles this fine:
http://babeljs.io/repl/#?experimental=true&playground=false&evaluate=true&loose=true&spec=true&code=var%20keys%20%3D%20%5B'a'%2C%20'b'%2C%20'c'%5D%3B%0A%0Avar%20a%20%3D%20%7B%0A%20%20b%3A%20Ember.computed(...Keys%2C%20function()%20%7B%0A%20%20%20%20%0A%20%20%7D)%0A%7D

—
Reply to this email directly or view it on GitHub
#15 (comment).

[stefanpenner]

@sebmck has informed me, that babel isn't as good as recast when it comes to preserving input style

[kamal]

Maybe simplest thing we can do is to detect the spread operator and call

Ember.computed.apply(Ember, KEYS.concat([function(){}])