Add qunit/mocha tests conversion to async/await #112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts from the
andThen
style acceptance tests...... into cleaner async/await style:
I only implemented mocha since that's what I use, but qunit could be added (ember-power-select has some example qunit tests using async/await style).
It doesn't handle custom async test helpers which need to be awaited. Maybe there could be a config option to list the names of additional async helpers.
It doesn't handle naming/scoping conflicts when merging
andThen
blocks. Babel will catch them if the code is invalid (e.g. reassign toconst
), otherwise the linter will catch them. For example:\