WIP Lint set chain #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mmun thanks! this looks really cool, I'll merge it later today. About |
|
If you want to finish this off differently feel free to rebase this commit or merge & finish the job :P |
|
👍 for the PR |
|
I'm not completely familiar with the internals of ember-watson. Would this handle usages like this, which also broke with Ember 2.0? const foo = store.createRecord('foo').set('bar', true);
foo.save(); |
|
Fyi jscs merged with eslint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tool is intended to help out with emberjs/ember.js#12095.
The point of the tool is to list all places where you may be using Ember.set of obj.set in a sketchy way, so that you can manually audit them.
It would be nice to give ember-watson first class support for linting instead of only source-to-source transformation. We might want to use JSCS because it has great support for displaying the offending code.