Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new fields: EventFilter.OrderChangeTypes and AmazonInvalidInputException.Details #665

Merged
merged 4 commits into from
Oct 8, 2023
Merged

Added new fields: EventFilter.OrderChangeTypes and AmazonInvalidInputException.Details #665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a337326
Added details to AmazonInvalidInputException
Aug 30, 2023
25776a2
Merge from original (#1)
TManITtech Aug 30, 2023
5b53b3e
Merge branch 'abuzuhri:main' into main
TManITtech Aug 30, 2023
6333337
Added new field EventFilter.OrderChangeTypes
TManITtech Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Source/FikaAmazonAPI/AmazonSpApiSDK/Models/Exceptions/AmazonException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,15 @@ public AmazonUnauthorizedException(string msg, RestResponse response = null) : b

public class AmazonInvalidInputException : AmazonException
{
public AmazonInvalidInputException(string msg, RestResponse response = null) : base(msg, response)
{
public string Details { get; set; }

public AmazonInvalidInputException(string msg, string details = null, RestResponse response = null) : base(msg, response)
{
this.Details = details;
//this.Data["Details"] = details;
}
}

public class AmazonQuotaExceededException : AmazonException
{
public AmazonQuotaExceededException(string msg, RestResponse response = null) : base(msg, response)
Expand Down
8 changes: 8 additions & 0 deletions Source/FikaAmazonAPI/AmazonSpApiSDK/Models/Notifications/EventFilter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,13 @@ public class EventFilter : AggregationFilter
[JsonProperty(PropertyName = "eventFilterType")]
public string EventFilterType { get; set; }

/// <summary>
/// Gets or Sets OrderChangeTypes
/// </summary>
[DataMember(Name = "orderChangeTypes", EmitDefaultValue = false)]
[JsonProperty(PropertyName = "orderChangeTypes")]
public IList<string> OrderChangeTypes { get; set; }


/// <summary>
/// Get the string presentation of the object
Expand All @@ -37,6 +44,7 @@ public override string ToString()
sb.Append("class EventFilter {\n");
sb.Append(" MarketplaceIds: ").Append(MarketplaceIds).Append("\n");
sb.Append(" EventFilterType: ").Append(EventFilterType).Append("\n");
sb.Append(" OrderChangeTypes: ").Append(OrderChangeTypes).Append("\n");
sb.Append("}\n");
return sb.ToString();
}
Expand Down
6 changes: 3 additions & 3 deletions Source/FikaAmazonAPI/FikaAmazonAPI.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
<Product>CSharp Amazon Sp API</Product>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<LangVersion>8.0</LangVersion>
<Version>1.7.2</Version>
<AssemblyVersion>1.7.2</AssemblyVersion>
<FileVersion>1.7.2</FileVersion>
<Version>1.7.3</Version>
<AssemblyVersion>1.7.3</AssemblyVersion>
<FileVersion>1.7.3</FileVersion>
<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
<PackageProjectUrl>https://github.com/abuzuhri/Amazon-SP-API-CSharp</PackageProjectUrl>
<PackageLicenseExpression>MIT</PackageLicenseExpression>
Expand Down
2 changes: 1 addition & 1 deletion Source/FikaAmazonAPI/Services/RequestService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ protected void ParseResponse(RestResponse response)
case "InvalidSignature":
throw new AmazonInvalidSignatureException(error.Message, response);
case "InvalidInput":
throw new AmazonInvalidInputException(error.Message, response);
throw new AmazonInvalidInputException(error.Message, error.Details, response);
case "QuotaExceeded":
throw new AmazonQuotaExceededException(error.Message, response);
case "InternalFailure":
Expand Down
Loading