Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed PII issue on next token by #709

Closed
wants to merge 3 commits into from
Closed

fixed PII issue on next token by #709

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0bafe17
fixed #702
Jan 29, 2024
943e82e
Merge branch 'main' of github.com:kevinvenclovas/Amazon-SP-API-CSharp
Jan 29, 2024
c60911d
Merge branch 'abuzuhri:main' into main
kevinvenclovas Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions Source/FikaAmazonAPI/Services/OrderService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
using System.Collections.Generic;
using System.Threading;
using System.Threading.Tasks;
using RestSharp;
using FikaAmazonAPI.AmazonSpApiSDK.Services;
using static FikaAmazonAPI.Utils.Constants;

namespace FikaAmazonAPI.Services
{
Expand Down Expand Up @@ -34,7 +37,7 @@
if (searchOrderList.IsNeedRestrictedDataToken && searchOrderList.RestrictedDataTokenRequest == null)
{
var restrictedResource = new RestrictedResource();
restrictedResource.method = Method.GET.ToString();

Check failure on line 40 in Source/FikaAmazonAPI/Services/OrderService.cs

View workflow job for this annotation

GitHub Actions / build 

'Method' is an ambiguous reference between 'FikaAmazonAPI.AmazonSpApiSDK.Models.Token.Method' and 'RestSharp.Method'

Check failure on line 40 in Source/FikaAmazonAPI/Services/OrderService.cs

View workflow job for this annotation

GitHub Actions / build 

'Method' is an ambiguous reference between 'FikaAmazonAPI.AmazonSpApiSDK.Models.Token.Method' and 'RestSharp.Method'
restrictedResource.path = OrdersApiUrls.Orders;
restrictedResource.dataElements = new List<string> { "buyerInfo", "shippingAddress" };

Expand Down Expand Up @@ -140,10 +143,17 @@

public async Task<OrdersList> GetGetOrdersByNextTokenAsync(string nextToken, ParameterOrderList searchOrderList)
{
List<KeyValuePair<string, string>> queryParameters = new List<KeyValuePair<string, string>>();
queryParameters.Add(new KeyValuePair<string, string>("NextToken", nextToken));
queryParameters.Add(new KeyValuePair<string, string>("MarketplaceIds", string.Join(",", searchOrderList.MarketplaceIds)));

var parameterOrderList = new ParameterOrderList
{
MarketplaceIds = searchOrderList.MarketplaceIds,
NextToken = nextToken,
IsNeedRestrictedDataToken = searchOrderList.IsNeedRestrictedDataToken,
RestrictedDataTokenRequest = searchOrderList.RestrictedDataTokenRequest
};

List<KeyValuePair<string, string>> queryParameters = parameterOrderList.getParameters();

await CreateAuthorizedRequestAsync(OrdersApiUrls.Orders, RestSharp.Method.Get, queryParameters);
var response = await ExecuteRequestAsync<GetOrdersResponse>(Utils.RateLimitType.Order_GetOrders);
return response.Payload;
Expand Down Expand Up @@ -172,7 +182,7 @@
if (parameter.IsNeedRestrictedDataToken && parameter.RestrictedDataTokenRequest == null)
{
var restrictedResource = new RestrictedResource();
restrictedResource.method = Method.GET.ToString();

Check failure on line 185 in Source/FikaAmazonAPI/Services/OrderService.cs

View workflow job for this annotation

GitHub Actions / build 

'Method' is an ambiguous reference between 'FikaAmazonAPI.AmazonSpApiSDK.Models.Token.Method' and 'RestSharp.Method'

Check failure on line 185 in Source/FikaAmazonAPI/Services/OrderService.cs

View workflow job for this annotation

GitHub Actions / build 

'Method' is an ambiguous reference between 'FikaAmazonAPI.AmazonSpApiSDK.Models.Token.Method' and 'RestSharp.Method'
restrictedResource.path = OrdersApiUrls.Order(parameter.OrderId);
restrictedResource.dataElements = new List<string> { "buyerInfo", "shippingAddress" };

Expand All @@ -199,7 +209,7 @@
if (ParameterBasedPII != null && ParameterBasedPII.IsNeedRestrictedDataToken && ParameterBasedPII.RestrictedDataTokenRequest == null)
{
var restrictedResource = new RestrictedResource();
restrictedResource.method = Method.GET.ToString();

Check failure on line 212 in Source/FikaAmazonAPI/Services/OrderService.cs

View workflow job for this annotation

GitHub Actions / build 

'Method' is an ambiguous reference between 'FikaAmazonAPI.AmazonSpApiSDK.Models.Token.Method' and 'RestSharp.Method'

Check failure on line 212 in Source/FikaAmazonAPI/Services/OrderService.cs

View workflow job for this annotation

GitHub Actions / build 

'Method' is an ambiguous reference between 'FikaAmazonAPI.AmazonSpApiSDK.Models.Token.Method' and 'RestSharp.Method'
restrictedResource.path = OrdersApiUrls.OrderItems(orderId);
restrictedResource.dataElements = new List<string> { "buyerInfo", "shippingAddress" };

Expand Down
Loading