Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed changes to Badger::Log/Badger::Log::File #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

klesteb
Copy link
Contributor

@klesteb klesteb commented Jan 17, 2017

I have made some changes that might be nice.

1) Decoupled the setting of the log level from the actual log output
2) Started using Badger::Timestamp to generate the timestamp
3) Added config variable for the change the callbacks for log output
4) Added config variable for changing the timestamp format
5) Added a method to change the callback for the log output
6) Added a "trace" level

I have not updated the documentation for this change, I have updated the tests for this change. This change
currently passes all tests. I will update the documentation if the change is accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant