Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank STP fields cause an error when we load the file #729

Open
ac2cz opened this issue Jan 30, 2022 · 2 comments
Open

Blank STP fields cause an error when we load the file #729

ac2cz opened this issue Jan 30, 2022 · 2 comments
Assignees
Labels
Milestone

Comments

@ac2cz
Copy link
Owner

ac2cz commented Jan 30, 2022

For example, when RF-Receiver Description was not completed then the STP Raw Queue could not be sent to the server. This is because it is read in with a tokenizer and it does not like blank fields.
image

The error needs to be fixed in Frame load(BufferedReader input)
Rather than tokenize the line we should split it.

@ac2cz ac2cz self-assigned this Jan 30, 2022
@ac2cz ac2cz added the Crash label Jan 30, 2022
@ac2cz
Copy link
Owner Author

ac2cz commented Feb 25, 2022

If the frame queue is corrupted because the line was not fully written then I think we also get a crash

@ac2cz
Copy link
Owner Author

ac2cz commented Mar 25, 2022

I have mitigated this by making sure that the setting always has a default value and can not be blank. But it should be fixed fully.

@ac2cz ac2cz added High and removed Crash labels Mar 25, 2022
@ac2cz ac2cz added this to the Release 1.12 milestone Aug 22, 2022
@ac2cz ac2cz modified the milestones: Release 1.12, Release 1.13 Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant