fix: Ensure enums are at the top of the components to avoid issue on recursive schema parsing #1163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bf95ad8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
RoXuS
force-pushed
the
enumAsFirst
branch
4 times, most recently
from
1657c8a to
b9c0c0a
Compare
…recursive schema parsing
There was a problem hiding this comment.
Copilot reviewed 4 out of 15 changed files in this pull request and generated no comments.
Files not reviewed (11)
- tests/spec/discriminator/snapshots/basic.test.ts.snap: Language not supported
- tests/spec/enumNamesAsValues/snapshots/basic.test.ts.snap: Language not supported
- tests/spec/enumNotFirstInComponents/snapshots/basic.test.ts.snap: Language not supported
- tests/spec/enumNotFirstInComponents/schema.json: Language not supported
- tests/spec/enums-2.0/snapshots/basic.test.ts.snap: Language not supported
- tests/spec/extractRequestBody/snapshots/basic.test.ts.snap: Language not supported
- tests/spec/extractResponseBody/snapshots/basic.test.ts.snap: Language not supported
- tests/spec/extractResponseError/snapshots/basic.test.ts.snap: Language not supported
- tests/spec/moduleNameFirstTag/snapshots/basic.test.ts.snap: Language not supported
- tests/spec/moduleNameIndex/snapshots/basic.test.ts.snap: Language not supported
- tests/spec/unionEnums/snapshots/basic.test.ts.snap: Language not supported
smorimoto
changed the title
smorimoto
previously approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The schema parser is recursive. When we parse the discriminators if the enums aren't yet parsed so they aren't used.
We have to be sure enums are at the top of the components list to ensure there are parsed before other components.
This fix #699.