Skip to content

refactor: replace GenerateApiParams with GenerateApiConfiguration config #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

smorimoto
Copy link
Collaborator

No description provided.

… config

Signed-off-by: Sora Morimoto <sora@morimoto.io>
@smorimoto smorimoto requested a review from Copilot May 17, 2025 01:10
@smorimoto smorimoto added the bug Something isn't working label May 17, 2025
Copy link

changeset-bot bot commented May 17, 2025

⚠️ No Changeset found

Latest commit: 2cca2d6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@smorimoto smorimoto linked an issue May 17, 2025 that may be closed by this pull request
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the API generation configuration to replace the old GenerateApiParams type with the new GenerateApiConfiguration and updates the loadConfig call accordingly.

  • Swap GenerateApiParams import with GenerateApiConfiguration
  • Change loadConfig<GenerateApiParams> to loadConfig<Partial<GenerateApiConfiguration["config"]>>
Comments suppressed due to low confidence (1)

index.ts:12

  • [nitpick] Using the GenerateApiConfiguration type alongside bracket notation for its config property may be confusing. If the intention is to load only the config portion, consider exporting and importing a dedicated GenerateApiConfig type to improve clarity.
GenerateApiConfiguration,

_
Signed-off-by: Sora Morimoto <sora@morimoto.io>
@smorimoto smorimoto marked this pull request as draft May 17, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poor type definitions for config
1 participant