Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use import pattern that supports windows external drives #930

Merged
merged 2 commits into from
Oct 29, 2024
Merged

use import pattern that supports windows external drives #930

merged 2 commits into from
Oct 29, 2024

Conversation

thechucklingatom
Copy link
Contributor

Closes #901

VeXell
VeXell reviewed Oct 27, 2024
View reviewed changes
Copy link

@VeXell VeXell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it works on windows

@VeXell
Copy link

VeXell commented Oct 27, 2024

@js2me Can you review this small fix please. thx

thechucklingatom and others added 2 commits October 29, 2024 20:35
@thechucklingatom @smorimoto
use import pattern that supports windows external drives
c53600d
@smorimoto
Cleanup
dd46e5e 
Signed-off-by: Sora Morimoto <sora@morimoto.io>
@smorimoto
Copy link
Collaborator

@thechucklingatom @VeXell Could you test with the latest commit?

@thechucklingatom
Copy link
Contributor Author

Seems to work as expected on my end.

@VeXell
Copy link

VeXell commented Oct 29, 2024

@smorimoto Yes. Looks like it works as expected. Thank you.

@smorimoto smorimoto merged commit 1d49b4e into acacode:main Oct 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VeXell VeXell VeXell left review comments

@smorimoto smorimoto smorimoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ESM path failure when importing a template
3 participants
@thechucklingatom @VeXell @smorimoto