Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl multi prop into select #23

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

impl multi prop into select #23

wants to merge 4 commits into from

Conversation

sparcscasio
Copy link
Contributor

요약 *

It closes #22

스크린샷

다중 선택 시
Select Component Example

multi = true일 때, 아무것도 선택 X -> error 출력
Select Component Example

이후 Task *

  • 없음

@sparcscasio sparcscasio added enhancement New feature or request frontend labels Oct 14, 2024
@sparcscasio sparcscasio self-assigned this Oct 14, 2024
@sparcscasio sparcscasio changed the title 22 impl multi prop into select impl multi prop into select Oct 14, 2024
wjeongchoi
wjeongchoi reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@wjeongchoi wjeongchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

폴더 정리를 한 번 해야할 것 같아서 기능 체크는 그거 후에 할게요!

지금 드롭다운 컴포넌트만 Select 폴더에 들어가 있는데 정작 Select는 Forms에 들어가 있어서, Select를 Select 폴더에 옮기고 index.tsx로 바꿔주세요
그리고 Select에서 사용하는 외부 컴포넌트가 있다면 그것도 Select 폴더에 옮겨주세요
혹시 애매한거 있으면 질문해주세요!

packages/web/src/common/components/Forms/Select.tsx Outdated Show resolved Hide resolved
@wjeongchoi
Copy link
Contributor

테스트 해보려고 하는데 PR에 예시 코드 추가해줄 수 있나요?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjeongchoi wjeongchoi Awaiting requested review from wjeongchoi

At least 1 approving review is required to merge this pull request.

Assignees

@sparcscasio sparcscasio

Labels
enhancement New feature or request frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

impl multi prop into select
2 participants
@sparcscasio @wjeongchoi