Refactor SearchSelect and fix Error #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
wjeongchoi
reviewed
Sep 30, 2024
wjeongchoi
reviewed
Sep 30, 2024
packages/web/src/common/components/Forms/SearchSelect/SearchItem.tsx
Outdated
Show resolved
Hide resolved
packages/web/src/common/components/Forms/SearchSelect/index.tsx
Outdated
Show resolved
Hide resolved
ChaeyeonAhn
commented
Sep 30, 2024
| placeholder={placeholder} | ||
| hasError={!!errorMessage} | ||
| disabled={disabled} | ||
| value={value} |
There was a problem hiding this comment.
여기가 value || selected 였는데 value로 바꿔서 텍스트 다 지워도 selected된 텍스트로 바뀌지 않게 수정했습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약 *
It closes #5
스크린샷
이후 Task *