gcc noclang take2 #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is 2024, so we can assume that both gcc and clang can support bpf. Moreover, we can assume that all clang from any descent Linux shall support a bpf output. So let's remove some checks which are complex to share for gcc and clang.
note: gcc does not support: -Wno-unknown-warning-option’ -Wno-gnu-variable-sized-type-not-at-end’ -Wno-compare-distinct-pointer-types’ usage: CLANG=gcc make or LLC=gcc make Should you need to compile using llc: LLC=llc-18 make -j $(nproc) WARNING: currently, the tests fail on my ARM64 CPU with gcc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming the pull request #27 is merged, then this pull request enables the usage of gcc for the bpf modules.
This pull request is currently a placeholder as a WIP.