Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix PPPOE SIGTERM #35

Merged
merged 1 commit into from
Feb 16, 2025
Merged

fix PPPOE SIGTERM #35

merged 1 commit into from
Feb 16, 2025

Conversation

vjardin
Copy link
Contributor

@vjardin vjardin commented Feb 16, 2025

The daemon does not quit in case of a SIGTERM when a PPPoE session is established but there is no PPPOE signaling traffic.

We can notice that it keeps blocking on recvmmsg() syscall:

[pid 262269] recvmmsg(46,  <unfinished ...>
[pid 262268] recvmmsg(44,  <unfinished ...>
[pid 262264] recvmmsg(43,  <unfinished ...>

Those fd are:

gtp-guard 262250 root   43u     pack            4610713      0t0 PPP_SES type=SOCK_RAW
gtp-guard 262250 root   44u     pack            4641817      0t0 PPP_DIS type=SOCK_RAW
gtp-guard 262250 root   46u     pack            4629533      0t0 PPP_SES type=SOCK_RAW

The daemon does not quit in case of a SIGTERM when a PPPoE session is
established but there is no PPPOE signaling traffic.

We can notice that it keeps blocking on recvmmsg() syscall:
[pid 262269] recvmmsg(46,  <unfinished ...>
[pid 262268] recvmmsg(44,  <unfinished ...>
[pid 262264] recvmmsg(43,  <unfinished ...>

Those fd are:
gtp-guard 262250 root   43u     pack            4610713      0t0 PPP_SES type=SOCK_RAW
gtp-guard 262250 root   44u     pack            4641817      0t0 PPP_DIS type=SOCK_RAW
gtp-guard 262250 root   46u     pack            4629533      0t0 PPP_SES type=SOCK_RAW
@acassen acassen merged commit 39f2617 into acassen:main Feb 16, 2025
10 checks passed
@vjardin vjardin deleted the vj_fixsigterm branch February 16, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants