Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MinionMadness #7

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

MinionMadness #7

wants to merge 8 commits into from

Conversation

JovannyEspinal
Copy link

No description provided.

itsJiaqi
itsJiaqi reviewed Aug 11, 2015
View reviewed changes
CharacterGenerator/MinionMadness/MinionDetailViewController.m
//

#import "MinionDetailViewController.h"
<<<<<<< HEAD
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You seem to have merge conflicts in your code - probably good to resolve that

@itsJiaqi
Copy link

Good general abstraction in the View/Controller structure
Good abstraction for listing out the questions/answers
I noticed that you tried to incorporate sounds which is really cool but I couldn't get it to work.

Good used of the List UI to list out all the minions
I couldn't get the Quiz portion to work on the simulator - not sure if that's because of my setup or your code.

General Design things:

  • You could have had 1 model for Minions and 1 model for Questions and 1 View/Controller for everything instead of a MinionViewController and QuestionsViewController

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JovannyEspinal @itsJiaqi @zoufishanmehdi