Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

style(src): improve clause components a11y - I57 #298

Merged
merged 1 commit into from
Feb 25, 2020
Merged

style(src): improve clause components a11y - I57 #298

merged 1 commit into from
Feb 25, 2020

Conversation

elit-altum
Copy link
Contributor

Issue #57

I have checked and modified all the elements which weren't complying with the WCAG 2.0 Standards i.e. the contrast ratio was lesser than 4.5:1

Changes

  • The following graphic should explain the changes made in a descriptive manner

Color-Codes-Solved

Related Issues

@jolanglinais jolanglinais added A11Y 🔓 Accessibility related Difficulty: Starter Type: Enhancement ✨ Improvement to process or efficiency labels Feb 25, 2020
@jolanglinais jolanglinais linked an issue Feb 25, 2020 that may be closed by this pull request
Michael-Grover
Michael-Grover previously approved these changes Feb 25, 2020
Copy link
Collaborator

@Michael-Grover Michael-Grover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jolanglinais
Copy link
Member

Could you update your commit and PR title with this as a guide?

@elit-altum
Copy link
Contributor Author

Could you update your commit and PR title with this as a guide?

Really sorry for this @irmerk
Would this be an appropriate commit message :

style: fixes clause components accessibility to WCAG2.0 - Fixes #57

@jolanglinais
Copy link
Member

I think this works: style(src): improve clause components a11y - I57

Signed-off-by: elit-altum <manan.sharma311@gmail.com>
@elit-altum
Copy link
Contributor Author

I think this works: style(src): improve clause components a11y - I57

Thank you for your help @irmerk .
I have squashed the commits and updated my branch as well. Please review!

@elit-altum
Copy link
Contributor Author

@Michael-Grover Sorry but I don't know how the review was dismissed. I think it was dismissed due to a force push I made after updating my branch. As mentioned in isaacs/github#1157. I did not do it intentionally, I am sorry for any inconvenience caused.

@jolanglinais jolanglinais changed the title Fixes contrast accessibility issues style(src): improve clause components a11y - I57 Feb 25, 2020
@jolanglinais jolanglinais merged commit 244017e into accordproject:master Feb 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A11Y 🔓 Accessibility related Difficulty: Starter Type: Enhancement ✨ Improvement to process or efficiency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contrast Minimum Accessibility
3 participants