refactor(library): Upgrade Library component implementation #411
Conversation
petrgazarov
force-pushed
the
petrgazarov/363/upgrade-library-component
branch
from
21385a3 to
a28c89e
Compare
Closes accordproject#363 Signed-off-by: Petr Gazarov <petrgazarov@gmail.com>
petrgazarov
force-pushed
the
petrgazarov/363/upgrade-library-component
branch
from
a28c89e to
0fd2d2d
Compare
jolanglinais
added
Type: Breaking Change 💥
Type: Enhancement ✨
| - `cicero-ui__library-search-input` : search input. | ||
| - `cicero-ui__library-card` : library card. An additional class of `item.itemType` will be added to the card, | ||
| so different CSS selectors can be used based on the item's `itemType` value. | ||
| - `cicero-ui__library-card-content` : content element inside a library item card. | ||
| - `cicero-ui__library-card-logo` : logo element inside a library item card. | ||
| - `cicero-ui__library-card-header` : header element inside a library item card. | ||
| - `cicero-ui__library-card-meta` : meta element inside a library item card. | ||
| - `cicero-ui__library-card-type` : item type name element inside a library item card. | ||
| - `cicero-ui__library-card-item-version` : version element inside a library item card. | ||
| - `cicero-ui__library-card-actions` : actions element inside a library item card. | ||
| - `cicero-ui__library-card-primary-btn` : primary button inside a library item card. | ||
| - `cicero-ui__library-card-secondary-btn` : secondary button inside a library item card. | ||
| - `cicero-ui__library-add-item-button` : add new library item button. | ||
| - `cicero-ui__library-upload-button` : upload new library item button. | ||
| - `cicero-ui__library-import-button` : import new library item button. |
There was a problem hiding this comment.
Curious if there is any reason for this syntax? We'll be needing to sync our className properties across markdown-editor and cicero-ui, so this would likely set the standard for that.
There was a problem hiding this comment.
No specific reason for choosing this one, @irmerk. The purpose for name-spacing here is to avoid clashes with the user's application code, as well as clashes with other components in cicero-ui library.
There was a problem hiding this comment.
👏
To go off of @irmerk's comment - We talked a bit about this on Thursday, but I like the cicero-ui__ prefix for class names, and I think we could use the same pattern across cicero-ui in other components. Interested to hear other people's thoughts too though!
|
Yeah I think |
Issue #363
Refactors
TemplateLibrarycomponentChanges
LibrarylibraryPropsprop, and makes other prop names more genericFlags