Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server) Add new /normalize/:template endpoint implementation #748

Merged
merged 9 commits into from
Sep 27, 2022

Conversation

mehmettokgoz
Copy link
Contributor

@mehmettokgoz mehmettokgoz commented Aug 31, 2022

Changes

  • Implemented /normalize endpoint for Cicero Server.
  • Added test cases for /normalize.
  • New fromArchive() and fromUrl() support

Flags

  • You have to send all the arguments as JSON field inside request.body
  • Documentation will be added later with Swagger UI PR.

Demo

Sample request.body:

{
    "sample":"## Late Delivery and Penalty.\n\n In case of delayed delivery except for Force Majeure cases,\n\"Dan\" (the Seller) shall pay to \"Steve\" (the Buyer) for every 2 days\nof delay penalty amounting to 10.5% of the total value of the Equipment\nwhose delivery has been delayed. Any fractional part of a days is to be\nconsidered a full days. The total amount of penalty shall not however,\nexceed 55% of the total value of the Equipment involved in late delivery.\nIf the delay is more than 15 days, the Buyer is entitled to terminate this Contract."
}

Response to sample request:

{
    "result": "Late Delivery and Penalty.\n----\n\nIn case of delayed delivery except for Force Majeure cases,\n\"Dan\" (the Seller) shall pay to \"Steve\" (the Buyer) for every 2 days\nof delay penalty amounting to 10.5% of the total value of the Equipment\nwhose delivery has been delayed. Any fractional part of a days is to be\nconsidered a full days. The total amount of penalty shall not however,\nexceed 55.0% of the total value of the Equipment involved in late delivery.\nIf the delay is more than 15 days, the Buyer is entitled to terminate this Contract."
}

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname

Mehmet Tokgöz added 5 commits August 31, 2022 16:18
Signed-off-by: Mehmet Tokgöz <mehmet.tokgoz@hazelcast.com>
Signed-off-by: Mehmet Tokgöz <mehmet.tokgoz@hazelcast.com>
Signed-off-by: Mehmet Tokgöz <mehmet.tokgoz@hazelcast.com>
Signed-off-by: Mehmet Tokgöz <mehmet.tokgoz@hazelcast.com>
Signed-off-by: Mehmet Tokgöz <mehmet.tokgoz@hazelcast.com>
@mehmettokgoz mehmettokgoz changed the title feat(server) Add new /normalize/:template endpoint feat(server) Add new /normalize/:template endpoint implementation Aug 31, 2022
Mehmet Tokgöz added 2 commits September 24, 2022 17:31
Signed-off-by: Mehmet Tokgöz <mehmet.tokgoz@hazelcast.com>
Signed-off-by: Mehmet Tokgöz <mehmet.tokgoz@hazelcast.com>
@coveralls
Copy link

coveralls commented Sep 24, 2022

Coverage Status

Coverage decreased (-0.03%) to 93.602% when pulling db0417a on mehmettokgoz:normalize into 2ac5276 on accordproject:master.

Signed-off-by: Mehmet Tokgöz <mehmet.tokgoz@hazelcast.com>
@mehmettokgoz mehmettokgoz marked this pull request as ready for review September 24, 2022 15:01
@mttrbrts mttrbrts enabled auto-merge (squash) September 27, 2022 14:55
@mttrbrts mttrbrts merged commit b21c6e3 into accordproject:master Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants