Skip to content
This repository has been archived by the owner on Feb 7, 2025. It is now read-only.

refactor(cicero-ui): remove prop dependency - I70 #107

Merged

Conversation

jolanglinais
Copy link
Member

Closes #70

Reduce prop reliance for cicero-ui

Changes

  • Remove styling props
  • Sync class names with Library component

Flags

  • Did not address tests

Related Issues

Author Checklist

  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname

Signed-off-by: irmerk <jolenelanglinais@gmail.com>
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@DianaLease
Copy link
Member

Sooo much cleaner 🙏

Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@jolanglinais
Copy link
Member Author

Just make sure e68ad08 is all good.

Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@jolanglinais jolanglinais merged commit e038e0c into accordproject:master Jun 3, 2020
@jolanglinais jolanglinais deleted the irmerk/i70/prop-reliance branch June 3, 2020 12:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce Prop Reliance
2 participants