Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation spam #854

Closed
sakulstra opened this issue Nov 20, 2019 · 3 comments · Fixed by #855
Closed

deprecation spam #854

sakulstra opened this issue Nov 20, 2019 · 3 comments · Fixed by #855

Comments

@sakulstra
Copy link
Contributor

We're currently getting spammed by

(node:8221) [DEP0091] DeprecationWarning: crypto.DEFAULT_ENCODING is deprecated.
(node:8221) [DEP0010] DeprecationWarning: crypto.createCredentials is deprecated. Use tls.createSecureContext instead.
(node:8221) [DEP0011] DeprecationWarning: crypto.Credentials is deprecated. Use tls.SecureContext instead.

warnings... which i think are related to this package. Will have a look myself when i find some time, but thought it might make sense to post my findings here in case someone wants to have a look.

nodejs/node#23203 (comment)

@pradel
Copy link
Member

pradel commented Nov 20, 2019

Thanks for reporting the issue, looks like it's coming from this file packages/password/src/utils/encryption.ts.
Replacing import * as crypto from 'crypto'; with import { createHash } from 'crypto'; should fix the warnings. Happy to accept a pr with the fix 👍

@acomito
Copy link

acomito commented Dec 7, 2019

Is this in the latest npm release? I just upgraded but still seeing this

(node:2816) [DEP0010] DeprecationWarning: crypto.createCredentials is deprecated. Use tls.createSecureContext instead.
(node:2816) [DEP0011] DeprecationWarning: crypto.Credentials is deprecated. Use tls.SecureContext instead.

@pradel
Copy link
Member

pradel commented Dec 9, 2019

@acomito I still didn't publish it, will create a new release this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants