Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add basic OAuth client docs #1080

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Conversation

tennox
Copy link
Contributor

@tennox tennox commented Dec 9, 2020

As discussed here: #875 (comment)

Issues: #875 and #1031

@tennox tennox changed the title Add basic OAuth docs docs: Add basic OAuth client docs Dec 9, 2020
@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #1080 (c3b3d47) into master (3f02186) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1080   +/-   ##
=======================================
  Coverage   95.24%   95.24%           
=======================================
  Files          81       81           
  Lines        1830     1830           
  Branches      408      408           
=======================================
  Hits         1743     1743           
  Misses         85       85           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f02186...c3b3d47. Read the comment docs.

@agustif
Copy link
Contributor

agustif commented Dec 9, 2020

Hey @tennox would be cool if you can make a separate nextcloud package for easy imports, at least I'm gonna do that when I can updating the Insta one and adding the FB one I've working for my project . But awesome start, thank you for contributing!!

@pradel
Copy link
Member

pradel commented Feb 1, 2021

@tennox thank you so much for the pr that's amazing 🚀

@pradel pradel merged commit 44b0f05 into accounts-js:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants