-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix on Mongo.createUser and Mongo.createSession on 4.X #1251
Conversation
🦋 Changeset detectedLatest commit: ae31566 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, could please add the changeset and remove the commented line? Will create a new release after it's merged
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1251 +/- ##
=======================================
Coverage 95.32% 95.32%
=======================================
Files 106 106
Lines 2396 2396
Branches 503 513 +10
=======================================
Hits 2284 2284
Misses 103 103
Partials 9 9
☔ View full report in Codecov by Sentry. |
Okay, I added a changeset. First time I've ever done that, so double check it to make sure it looks right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please delete the yarn.lock and revert the change made to package.json, then we are good to go!
How are we doing on this? Just ran into the error again today, and going through the a local patch instead of deploying this improved version of the library. |
2 weeks later, having to sloppy patch another server. 😞 |
Bug fix for #1250