fix description not available and optimize sastjob with aiohttp and asyncio for faster execution #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In API v9.5, The field 'htmlDesc' has been deprecated
pishone-accuknox
changed the title
Vishal-42
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a fix for Description not Available (CNAPP-17258) as well as optimizations for faster executions.
In SQ API v9.5, the field 'htmlDesc' has been deprecated. This fix will fetch description from 'descriptionSections' and put it as an array of objects.
Provides optimization for sastjob with concurrent API calls using aiohttp.
Execution time of 'ask-ada' before optimization: 1h, 32m, 29s
After optimization: 43s
There's no notable difference in memory usage either:
