Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support observability for containerized workloads #514

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

Ankurk99
Copy link
Contributor

No description provided.

@Ankurk99 Ankurk99 requested a review from seswarrajan July 29, 2022 03:54
src/systempolicy/systemPolicy.go Outdated Show resolved Hide resolved
src/systempolicy/systemPolicy.go Outdated Show resolved Hide resolved
@Ankurk99 Ankurk99 marked this pull request as draft August 14, 2022 17:27
@Ankurk99 Ankurk99 force-pushed the latest_observability branch 3 times, most recently from a8c46f0 to d56acdb Compare August 16, 2022 06:33
@Ankurk99 Ankurk99 marked this pull request as ready for review August 16, 2022 06:33
Copy link
Contributor

@nyrahul nyrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. Just one change in the defaults in conf file.

src/conf/local-file.yaml Outdated Show resolved Hide resolved
Signed-off-by: Ankur Kothiwal <ankur.kothiwal@accuknox.com>
@Ankurk99 Ankurk99 force-pushed the latest_observability branch from d56acdb to 6cd61f8 Compare August 16, 2022 07:20
Copy link
Contributor

@nyrahul nyrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nyrahul nyrahul merged commit 641bef0 into accuknox:dev Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants