Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package discovery-engine as a systemd service #524

Merged
merged 1 commit into from
Aug 16, 2022
Merged

package discovery-engine as a systemd service #524

merged 1 commit into from
Aug 16, 2022

Conversation

Ankurk99
Copy link
Contributor

Signed-off-by: Ankur Kothiwal ankur.kothiwal@accuknox.com

@Ankurk99 Ankurk99 marked this pull request as draft August 16, 2022 09:26
@Ankurk99 Ankurk99 force-pushed the systemd branch 3 times, most recently from 803eddb to 4baabee Compare August 16, 2022 18:24
@Ankurk99 Ankurk99 marked this pull request as ready for review August 16, 2022 18:55
nyrahul
nyrahul requested changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@nyrahul nyrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, except that the user=root is enabled for knoxAutoPolicy.

src/packaging/discovery-engine.service Outdated Show resolved Hide resolved
seswarrajan
seswarrajan reviewed Aug 16, 2022
View reviewed changes
Copy link
Contributor

@seswarrajan seswarrajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly address review comments if possible or it can be handled in later release.

src/.goreleaser.yml Show resolved Hide resolved
src/packaging/post-install.sh Show resolved Hide resolved
@Ankurk99
package discovery-engine as a systemd service
b516729 
Signed-off-by: Ankur Kothiwal <ankur.kothiwal@accuknox.com>
nyrahul
nyrahul approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@nyrahul nyrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nyrahul nyrahul merged commit f1f300f into accuknox:dev Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seswarrajan seswarrajan seswarrajan left review comments

@nyrahul nyrahul nyrahul approved these changes

@daemon1024 daemon1024 Awaiting requested review from daemon1024

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ankurk99 @nyrahul @seswarrajan