Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover k8s generic net policy from kubearmor logs #564

Merged
merged 5 commits into from
Oct 17, 2022
Merged

Discover k8s generic net policy from kubearmor logs #564

merged 5 commits into from
Oct 17, 2022

Conversation

seswarrajan
Copy link
Contributor

Signed-off-by: Eswar Rajan Subramanian eswar@accuknox.com

Signed-off-by: Eswar Rajan Subramanian <eswar@accuknox.com>
Signed-off-by: Eswar Rajan Subramanian <eswar@accuknox.com>
Copy link
Contributor

@nyrahul nyrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Great work! Just one minor comment.

src/plugin/k8sNetwork.go Outdated Show resolved Hide resolved
Signed-off-by: Eswar Rajan Subramanian <eswar@accuknox.com>
Signed-off-by: Eswar Rajan Subramanian <eswar@accuknox.com>
Copy link
Contributor

@Ankurk99 Ankurk99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some lint errors, otherwise looks good

src/networkpolicy/helperFunctions.go Outdated Show resolved Hide resolved
Signed-off-by: Eswar Rajan Subramanian <eswar@accuknox.com>
@Ankurk99
Copy link
Contributor

@seswarrajan Can you please squash the commits? Then let's merge this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants