Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to deploy discovery-engine in accuknox-agents namespace #620

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Change to deploy discovery-engine in accuknox-agents namespace #620

merged 1 commit into from
Dec 2, 2022

Conversation

seswarrajan
Copy link
Contributor

Signed-off-by: Eswar Rajan Subramanian eswar@accuknox.com

Signed-off-by: Eswar Rajan Subramanian <eswar@accuknox.com>
Copy link
Contributor

@achrefbensaad achrefbensaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ankurk99
Copy link
Contributor

Ankurk99 commented Dec 1, 2022

Hey @seswarrajan, if we try to install using the README manifest will it be directly deployed in the accuknox-agent ns or would we have to pass the -n accuknox-agent flag?
edit: Talking about this kubectl apply -f https://raw.githubusercontent.com/accuknox/discovery-engine/dev/deployments/k8s/deployment.yaml

@seswarrajan
Copy link
Contributor Author

Hey @seswarrajan, if we try to install using the README manifest will it be directly deployed in the accuknox-agent ns or would we have to pass the -n accuknox-agent flag? edit: Talking about this kubectl apply -f https://raw.githubusercontent.com/accuknox/discovery-engine/dev/deployments/k8s/deployment.yaml

Hi @Ankurk99
It will directly deploy in accuknox-agents ns. Even if accuknox-agents ns is not available, it will create one and then deploy

@yasin-cs-ko-ak
Copy link
Contributor

@seswarrajan But now we are changed the matchLabels in kubearmor-client for discovery-engine from "container: knoxautopolicy" to "app: discovery-engine". so this won't cause any problems?

@Ankurk99 Ankurk99 merged commit def3bdf into accuknox:dev Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants