Policy name randomizer for network-policy #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create policy name using hash method same as system-policy Signed-off-by: Eswar Rajan Subramanian <eswar@accuknox.com>
wazir-ahmed
reviewed
Mar 13, 2023
wazir-ahmed
approved these changes
Mar 13, 2023
Co-authored-by: Wazir Ahmed <wazir@accuknox.com>
Ankurk99
pushed a commit
to Ankurk99/auto-policy-discovery
that referenced
this pull request
Mar 20, 2023
* Policy name randomizer using hash method for network-policy Signed-off-by: Eswar Rajan Subramanian <eswar@accuknox.com> Co-authored-by: Wazir Ahmed <wazir@accuknox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Discovery-engine discovers both system and network. For system policies, the policy name is created based on hash of certain policy fields which are unique. Hence on multiple reboots/restarts of DE, the policy name remains the same.
In case of network policy, the name is based on randomizer. Which is causing the duplicate policies being written to policy_yaml in SaaS's DB.
Solution
Adding hash based naming mechanism similar to system policy resolves this issue.
PR
This PR contains the randomization based on unique fields of a policy.
Signed-off-by: Eswar Rajan Subramanian eswar@accuknox.com