Display summary data per deployment #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vishnusomank Can you share the output as well? Also, the summary data may vary per pod if someone exec'd into that particular pod, is that something we should consider? |
@Vyom-Yadav there is no change in the codebase we are only sending the data arranged by deployment name instead of pod name. So internally the storage and function calls are almost the same. You can refer this PR for output kubearmor/kubearmor-client#299 |
seswarrajan
reviewed
Apr 5, 2023
Ankurk99
suggested changes
Apr 10, 2023
Ankurk99
reviewed
Apr 16, 2023
Ankurk99
reviewed
Apr 16, 2023
Ankurk99
approved these changes
Apr 17, 2023
- Modified the observability to include Summary data per deployment - Added deployment name to struct PodInfo - Modified codebase to get details of replicasets and statefulset along with deployments - Modified codebase to include deployment name as part of PodInfo Signed-off-by: Vishnu Soman <vishnu@accuknox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #696
Related PR's