Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace utils with views #134

Closed
b1rger opened this issue Dec 5, 2024 · 0 comments · Fixed by #135 or #136
Closed

Replace utils with views #134

b1rger opened this issue Dec 5, 2024 · 0 comments · Fixed by #135 or #136

Comments

@b1rger
Copy link
Contributor

b1rger commented Dec 5, 2024

The utils module is a remnant from other django apps where it contained additional logic. It now only contains one method for fetching the imprint. The imprint logic is not used anywhere else, so it can be part of its own individual view. This would also be a more Djangoish way.

@b1rger b1rger changed the title Replace utils with view Replace utils with views Dec 5, 2024
b1rger added a commit that referenced this issue Dec 5, 2024
The `utils` module is a remnant from other Django apps where it
contained additional logic. It now only contains one method for fetching
the imprint. The imprint logic is not used anywhere else, so it can be
part of its own individual view, which is a more Django standardized way
of implementing the imprint functionality.

Closes: #134
b1rger added a commit that referenced this issue Dec 9, 2024
The `utils` module is a remnant from other Django apps where it
contained additional logic. It now only contains one method for fetching
the imprint. The imprint logic is not used anywhere else, so it can be
part of its own individual view, which is a more Django standardized way
of implementing the imprint functionality.

Closes: #134
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant