Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of person_detail_generic.html #397

Closed
b1rger opened this issue Nov 8, 2023 · 0 comments · Fixed by #470 or #446
Closed

Get rid of person_detail_generic.html #397

b1rger opened this issue Nov 8, 2023 · 0 comments · Fixed by #470 or #446
Assignees
@gythaogg
Labels
app-entities Anything to do with entities – the models central to an APIS app breaking-change Changes which may cause errors/failures without prior inspection/revision of other code or config easy Should be an easy fix

Comments

@b1rger
Copy link
Contributor

b1rger commented Nov 8, 2023

We decided that we don't want to make any assumptions about the ontology - therefore we should not expect the ontology to contain a person entity. But even if the ontology contains a person entity, the generic template is generic enough to provide a detail view for persons
@b1rger b1rger added app-entities Anything to do with entities – the models central to an APIS app breaking-change Changes which may cause errors/failures without prior inspection/revision of other code or config labels Nov 8, 2023
@b1rger b1rger added the easy Should be an easy fix label Nov 14, 2023
gythaogg added a commit that referenced this issue Dec 11, 2023
@gythaogg
feat(apis_entites)!: remove person detail template
da5beb7 
apis_entities should not assume the presence of a "person" model as it
is not present in apis_entities.

BREAKING CHANGE: any template in your ontology that inherits from the
person_detail_generic template needs to point to the detail_generic template instead

closes #397
@gythaogg gythaogg mentioned this issue Dec 11, 2023
Merged
gythaogg added a commit that referenced this issue Dec 11, 2023
@gythaogg
feat(apis_entites)!: remove person detail template
2267e3c 
apis_entities should not assume the presence of a "person" model as it
is not present in apis_entities.

BREAKING CHANGE: any template in your ontology that inherits from the
person_detail_generic template needs to point to the detail_generic template instead

closes #397
gythaogg added a commit that referenced this issue Dec 11, 2023
@gythaogg
feat(apis_entites)!: remove person detail template
ccd1bb6 
apis_entities should not assume the presence of a "person" model as it
is not present in apis_entities.

BREAKING CHANGE: any template in your ontology that inherits from the
person_detail_generic template needs to point to the
detail_generic template instead

closes #397
b1rger pushed a commit that referenced this issue Dec 11, 2023
@gythaogg @b1rger
feat(apis_entites)!: remove person detail template
75753d4 
apis_entities should not assume the presence of a "person" model as it
is not present in apis_entities.

BREAKING CHANGE: any template in your ontology that inherits from the
person_detail_generic template needs to point to the
detail_generic template instead

closes #397
@github-actions github-actions bot mentioned this issue Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gythaogg gythaogg

Labels
app-entities Anything to do with entities – the models central to an APIS app breaking-change Changes which may cause errors/failures without prior inspection/revision of other code or config easy Should be an easy fix
Projects
None yet
Milestone
No milestone
2 participants
@b1rger @gythaogg