Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid fo apis_entities.views.getGeoJson* and apis_entities.management.commands.serialize_to_cidoc #575

Closed
b1rger opened this issue Jan 30, 2024 · 1 comment · Fixed by #598
Closed

Get rid fo apis_entities.views.getGeoJson* and apis_entities.management.commands.serialize_to_cidoc #575

b1rger opened this issue Jan 30, 2024 · 1 comment · Fixed by #598
Assignees
@b1rger
Labels
breaking-change Changes which may cause errors/failures without prior inspection/revision of other code or config

Comments

@b1rger
Copy link
Contributor

b1rger commented Jan 30, 2024 

apis_core/apis_entities/management/commands/serialize_to_cidoc.py:203:34: F821 Undefined name `GenericVocabsSerializer`
apis_core/apis_entities/management/commands/serialize_to_cidoc.py:204:25: F821 Undefined name `VocabToSkos`
apis_core/apis_entities/views.py:224:34: F821 Undefined name `Place`
apis_core/apis_entities/views.py:300:15: F821 Undefined name `relation`

(reason is #521)
@b1rger b1rger self-assigned this Jan 30, 2024
@b1rger b1rger added needs-attention This issue or pull request is in need of discussion, information, assessment by team members breaking-change Changes which may cause errors/failures without prior inspection/revision of other code or config labels Jan 30, 2024
@sennierer
Copy link
Collaborator

we can remove both of them and also remove SPARQLWrapper dep

@sennierer sennierer removed the needs-attention This issue or pull request is in need of discussion, information, assessment by team members label Jan 31, 2024
b1rger added a commit that referenced this issue Jan 31, 2024
@b1rger
chore(apis_entities): remove unused, non functional code
5cd5bbc 
This removes the `serialize_to_cidoc` management command which was
specific to models from legacy APIS, as well as the `GeoJSON` views,
which where also specific to models from legacy APIS.
The `serialize_to_cidoc` was also the only thing depending on
SPARQLWrapper, so we are getting rid of this dependency, too.

Closes: #575
@b1rger b1rger mentioned this issue Jan 31, 2024
Merged
b1rger added a commit that referenced this issue Feb 6, 2024
@b1rger
chore(apis_entities): remove unused, non functional code
9dea046 
This removes the `serialize_to_cidoc` management command which was
specific to models from legacy APIS, as well as the `GeoJSON` views,
which where also specific to models from legacy APIS.
The `serialize_to_cidoc` was also the only thing depending on
SPARQLWrapper, so we are getting rid of this dependency, too.

Closes: #575
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@b1rger b1rger

Labels
breaking-change Changes which may cause errors/failures without prior inspection/revision of other code or config
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(apis_entities): remove unused, non functional code acdh-oeaw/apis-core-rdf
2 participants
@sennierer @b1rger