Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

birger/512 uri #1463

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

birger/512 uri #1463

wants to merge 6 commits into from

Conversation

b1rger
Copy link
Contributor

@b1rger b1rger commented Nov 29, 2024 •
edited
Loading

  • feat(apis_metainfo): add a GenericForeignKey to the Uri model
  • feat(apis_entities): update AbstractEntity to work with generic uri
  • feat(apis_relations): update GenericTripleForm to work with generic uri
  • feat(generic): update Enrich view to work with generic uri
  • feat(utils): update create_object_from_uri to work with generic uri

Closes: #512

@b1rger b1rger force-pushed the birger/512-uri branch 2 times, most recently from 2946903 to ed318dc Compare November 29, 2024 09:31
@b1rger b1rger marked this pull request as ready for review November 29, 2024 09:34
@b1rger b1rger added the needs-attention This issue or pull request is in need of discussion, information, assessment by team members label Dec 2, 2024
@sennierer sennierer removed the needs-attention This issue or pull request is in need of discussion, information, assessment by team members label Dec 3, 2024
@b1rger b1rger force-pushed the birger/512-uri branch 4 times, most recently from 283842b to a7f35fd Compare December 4, 2024 11:12
@b1rger
feat(apis_metainfo): replace Uri.root_object with GenericForeignKey
2299b1e 
The `Uri` should allow to point to any model instance, not only to models
that inherit from `RootObject`. Therefore we introduce a
GenericForeignKey. The migration copies the values of existing
`root_object` pointers to the generic foreign key. The `root_object`
field is then dropped from the model.
@b1rger b1rger requested a review from sennierer December 17, 2024 09:38
@b1rger b1rger force-pushed the birger/512-uri branch 3 times, most recently from ea60a2f to a387d4d Compare December 17, 2024 09:55
@b1rger
feat(apis_entities): update create_default_uri to use generic uri
500273b 
The Uri model now uses a generic foreign key instead of the direct
foreign key to the RootObject. This commit updates all occurences
of `root_object` to use the generic foreign key instead.
@b1rger
feat(apis_relations): update GenericTripleForm to work with generic uri
2097256 
The `Uri` model now uses a generic foreign key instead of the direct
foreign key to the `RootObject`. This commit updates all occurences
of `root_object` to instead use the generic foreign key.
@b1rger
feat(generic): update Enrichview & GenericModel to work with generic uri
8a1ea3b 
The `Uri` model now uses a generic foreign key instead of the direct
foreign key to the `RootObject`. This commit updates all occurences of
`root_object` to use the generic foreign key instead.
@b1rger
feat(utils): update create_object_from_uri to work with generic uri
bc40eda 
The `Uri` model now uses a generic foreign key instead of the direct
foreign key to the `RootObject`. This commit updates all occurences of
`root_object` to use the generic foreign key instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sennierer sennierer Awaiting requested review from sennierer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make URI more generic
2 participants
@b1rger @sennierer