Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import scripts: update references to TextChoices #188

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Import scripts: update references to TextChoices #188

merged 3 commits into from
Sep 4, 2024

Conversation

koeaw
Copy link
Collaborator

@koeaw koeaw commented Sep 3, 2024

No description provided.

@koeaw koeaw force-pushed the kk/refactor/import_scripts branch from 055eba8 to 6d593c0 Compare September 3, 2024 11:30
@koeaw
refactor(imports): adapt references to choices
56e1cae 
Change references to TextChoices for matching
Character relevancy, fictionality when importing
from Excel sheets to German labels following
recent updates to choices values in models.py
and the DB.
@koeaw koeaw force-pushed the kk/refactor/import_scripts branch from 6d593c0 to 56e1cae Compare September 3, 2024 11:30
@koeaw koeaw requested a review from babslgam September 3, 2024 11:31
@koeaw
Copy link
Collaborator Author

koeaw commented Sep 3, 2024

I'm not entirely sure how ArrayFields handle the order of choices values, but would assume there is some system behind it (either by the order the choices appear in in models or alphabetically?).

Since I found that Character fictionality returns two distinct values for the "historische Figur" + "mythologische Figur" combo but other ArrayFields don't show this behaviour, I changed the order of values for "M/R" to match how they appear in the CharacterFictionality class.

babslgam
babslgam approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@babslgam babslgam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving without testing due to lack of time

@koeaw koeaw merged commit 4e6dcb7 into deploy Sep 4, 2024
3 checks passed
@koeaw koeaw deleted the kk/refactor/import_scripts branch September 4, 2024 10:47
sennierer added a commit that referenced this pull request Dec 5, 2024
@sennierer
fix: change facet filter to overlap
d366504 
resolves gitlab issues #145 #188 #184 #186
@sennierer sennierer mentioned this pull request Dec 5, 2024
Merged
sennierer added a commit that referenced this pull request Dec 5, 2024
@sennierer
fix: change facet filter to overlap
a5b6b9e 
resolves gitlab issues #145 #188 #184 #186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babslgam babslgam babslgam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koeaw @babslgam