Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PersonImporter inherits from different class than other importers #100

Closed
koeaw opened this issue Jan 21, 2025 · 1 comment · Fixed by #101
Closed

PersonImporter inherits from different class than other importers #100

koeaw opened this issue Jan 21, 2025 · 1 comment · Fixed by #101
Labels
app-entities Anything to do with the model classes central to the ontology data To do with the application's data and data handling

Comments

@koeaw
Copy link
Collaborator

koeaw commented Jan 21, 2025

Based on what the other importer( stub)s look like, I'm assuming PersonImporter too should inherit from BaseEntityImporter, not GenericModelImporter?

apis-instance-tbf/apis_ontology/importers.py

Line 33 in a498786

class PersonImporter(GenericModelImporter):

@koeaw koeaw added data To do with the application's data and data handling app-entities Anything to do with the model classes central to the ontology labels Jan 21, 2025
koeaw added a commit that referenced this issue Jan 21, 2025
@koeaw
fix(importers): inherit from BaseEntityImporter

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
19b242e 
Set `PersonImporter` to inherit from `BaseEntityImporter`
instead of `GenericModelImporter`, like other importers/
importer stubs.

Closes: #100
koeaw added a commit that referenced this issue Jan 21, 2025
@koeaw
fix(importers): inherit from BaseEntityImporter

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
91967c3 
Set `PersonImporter` to inherit from `BaseEntityImporter`
instead of `GenericModelImporter`, like other existing
importers/importer stubs.

Closes: #100
@koeaw koeaw mentioned this issue Jan 21, 2025
Merged
@koeaw
Copy link
Collaborator Author

koeaw commented Jan 21, 2025

Discussed at JF -> yes, this inherits from the wrong class.

koeaw added a commit that referenced this issue Jan 21, 2025
@koeaw
fix(importers): inherit from BaseEntityImporter

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
486932c 
Set `PersonImporter` to inherit from `BaseEntityImporter`
instead of `GenericModelImporter`, like other existing
importers/importer stubs.

Closes: #100
@koeaw koeaw closed this as completed in bda20a1 Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app-entities Anything to do with the model classes central to the ontology data To do with the application's data and data handling
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(importers): inherit from BaseEntityImporter acdh-oeaw/apis-instance-tbf
1 participant
@koeaw