Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for lobid URL-Regex pattern #14

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

csae8092
Copy link
Member

a lobid URL like https://lobid.org/gnd/4113209-9 was not recognized

@csae8092 csae8092 requested a review from zozlak October 28, 2024 12:10
@zozlak
Copy link
Member

zozlak commented Oct 28, 2024

Do you have an example for the ending (?:/.*)??

@csae8092
Copy link
Member Author

Do you have an example for the ending (?:/.*)??

i simply copied the pattern from gnd to gnd-lobid as I don't want to deal myself with regex-patterns

@zozlak
Copy link
Member

zozlak commented Oct 28, 2024

Because the rest of the GND pattern is the gnd service API part which may or may not be applicable here. I will strip it for now.

@zozlak
Copy link
Member

zozlak commented Oct 28, 2024

Ok, the API description is here: https://lobid.org/gnd/api and it says it can optionally end with .json, .rdf, .ttl or .nt

@zozlak zozlak merged commit 3ec2e2e into master Oct 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants