Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update formats.json #7

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

MaximilianBailoni
Copy link

No description provided.

Copy link
Contributor

@bellerophons-pegasus bellerophons-pegasus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test funktioniert. Aber den mergen wir mal nicht, sondern dann die gesamte Datei

Copy link
Contributor

@bellerophons-pegasus bellerophons-pegasus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generell wurden die Felder 'ARCHE docs' und 'DataType' vertauscht (siehe die ersten Kommentare).

Wenn bereits ein Eintrag unter 'name' stand, dann ist das ein von mir intensiv recherchierter Eintrag und sollte so auch belassen werden.

Am Montag schaue ich mir das noch weiter im Detail an

@@ -1,93 +1,99 @@
[
{
"ARCHE_category" : "https://vocabs.acdh.oeaw.ac.at/archecategory/dataset",
"ARCHE_docs" : "",
"ARCHE_docs" : "test",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bitte 'test' entfernen

"Magic_number" : "",
"PRONOM_ID" : "",
"comment" : "",
"extensions" : [
"cpg"
],
"name" : ""
"name" : "Manga Studio"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das ist in diesem Fall nicht korrekt. Viel wahrscheinlicher ist das: https://docs.fileformat.com/system/cpg/

"Magic_number" : "",
"PRONOM_ID" : "",
"comment" : "",
"extensions" : [
"cpg"
],
"name" : ""
"name" : "Manga Studio"
},
{
"ARCHE_category" : "https://vocabs.acdh.oeaw.ac.at/archecategory/dataset",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

},
{
"ARCHE_category" : "https://vocabs.acdh.oeaw.ac.at/archecategory/dataset",
"ARCHE_docs" : "",
"ARCHE_docs" : "Tables & Spreadsheets",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das hier bitte leer lassen

"ARCHE_conformance": "preferred",
"DataType" : "Text file",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hier bitte 'Tables & Spreadsheets' eintragen

"MIME_type" : [
"text/csv"
],
"MIME_type" : ["pplication/csv, text/x-csv, application/x-csv, text/x-comma-separated-values, text/comma-separated-values"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fehlt ein 'a' am Anfang

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Außerdem sind die von dir gelisteten MIME_types nicht die aktuell validen, das ist tatsächlich nur text/csv (siehe csv in https://www.iana.org/assignments/media-types/media-types.xhtml)

"extensions" : [
"csv"
],
"name" : "Comma-Separated Values"
},
{
"ARCHE_category" : "https://vocabs.acdh.oeaw.ac.at/archecategory/dataset",
"ARCHE_docs" : "",
"ARCHE_docs" : "Databases",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Databases gehört unter "DataType"

ARCHE docs ist für einen späteren Link auf unsere Dokumentation mit mehr Infos zu den Formaten gedacht

"ARCHE_conformance": "accepted",
"DataType" : "Text file",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ersetzen durch 'Databases'

"extensions" : [
"dxf"
],
"name" : "Drawing Interchange Format (Autodesk)"
"name" : "Drawing Interchange File"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Der ursprüngliche Wert war schon korrekt

Copy link
Contributor

@bellerophons-pegasus bellerophons-pegasus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jetzt bin ich mal mit den Kommentaren durch. Es wird eh noch mehrere Schleifen brauchen, da, was du hoffentlich gelernt hast, das mit den Formaten nicht immer eindeutig ist. Das ist dann aber unsere Sache.

Was du noch tun könntest: Schau mal, ob du ein valides json erstellst. Gerade bei mehreren Werten benötigt man Listen (habe ich anfangs auch nicht sauber gemacht) und die Syntax stimmt nicht immer. Hier kann man JSON validieren: https://jsonlint.com/

},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hui!
Da hast du ja alle PDF-Varianten einzeln eingetragen. Das ist etwas viel, zumal nur PDF/A-1 und PDF/A-2 preferred sind. Die anderen nur accepted.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bitte entferne alles von Zeile 458-676 und von Zeile 939-1245-

"extensions" : [
"pdf"
],
"name" : "other PDF variants"
"name" : "Portable Document Format"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All other PDF variants

},
{
"ARCHE_category" : "https://vocabs.acdh.oeaw.ac.at/archecategory/text",
"ARCHE_docs" : "",
"dataType" : "PDF documents",
"ARCHE_docs" : "PDF",
"ARCHE_conformance": "preferred",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bitte auf 'accepted' setzen

@@ -176,16 +189,17 @@
},
{
"ARCHE_category" : "https://vocabs.acdh.oeaw.ac.at/archecategory/audioVisual",
"ARCHE_docs" : "",
"ARCHE_docs" : "Images (Raster)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gehört in DataType

"Further_specifications" : "",
"IANA_reference" : "",
"IANA_reference" : "W3C",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W3C ist viel zu unspezifisch: Besser ist https://html.spec.whatwg.org/ geeignet

"extensions" : [
"xml"
],
"name" : "eXtensible Markup Language"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Der ursprüngliche Wert passt so. Das X ist groß, um zu zeigen wo das x in xml herkommt

"extensions" : ["bak"],
"name" : "binary export formats for databases"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das bitte unter comment einfügen

"comment" : "",
"extensions" : ["db"],
"name" : "binary export format for databases"
"name" : "Paradox Database Table"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das ist nicht unbedingt immer Paradox Database Table, da es sich um ein sehr generisches Datenbankformat handelt

"comment" : "",
"extensions" : ["doc"],
"name" : "Microsoft Word"
"name" : "MS Word Doc"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Microsoft Word Document

"comment" : "",
"extensions" : ["dwg"],
"name" : "Drawing (Autodesk)"
"name" : "Drawing Interchange(Autodesk)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drawing ist correct;
Drawing interchange wäre dxf

@zozlak
Copy link
Member

zozlak commented May 8, 2024

@bellerophons-pegasus what is the status of this pull request? Should it be merged, denied or do you plan to clean it up further?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants