Skip to content

Commit

Permalink
Repo::getResourceByIdsAsync(): remove technical search metadata befor…
Browse files Browse the repository at this point in the history
…e passing the meta to the resource
  • Loading branch information
zozlak committed Oct 1, 2024
1 parent 19ea4aa commit b4d8d49
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/acdhOeaw/arche/lib/Repo.php
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
use quickRdfIo\NQuadsSerializer;
use quickRdfIo\Util as RdfIoUtil;
use termTemplates\QuadTemplate as QT;
use termTemplates\PredicateTemplate as PT;
use acdhOeaw\arche\lib\exception\Conflict;
use acdhOeaw\arche\lib\exception\Deleted;
use acdhOeaw\arche\lib\exception\NotFound;
Expand Down Expand Up @@ -489,7 +490,10 @@ public function getResourceByIdsAsync(array $ids, ?string $class = null): RepoRe
return new RejectedPromise(new NotFound());
case 1;
$class = $class ?? self::$resourceClass;
$res = new $class($matches[0], $this);
$res = new $class($matches[0], $this);
$graph->delete(new PT($this->schema->searchMatch));
$graph->delete(new PT($this->schema->searchOrder));
$graph->delete(new PT($this->schema->searchOrderValue));
$res->setGraph($graph);

Check failure on line 497 in src/acdhOeaw/arche/lib/Repo.php

View workflow job for this annotation

GitHub Actions / phpstan

Call to an undefined method object::setGraph().
return $res;
default:
Expand Down
18 changes: 18 additions & 0 deletions tests/RepoTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,24 @@ public function testSearchById(): void {

$res2 = self::$repo->getResourceById($id);
$this->assertEquals($res1->getUri(), $res2->getUri());
$meta = [
'getGraph()' => $res2->getGraph(),
'getMetadata()' => $res2->getMetadata(),
];
foreach ($meta as $k => $v) {
$this->assertTrue($v->none(new PT(self::$schema->searchMatch)), $k);
$this->assertTrue($v->none(new PT(self::$schema->searchOrder)), $k);
$this->assertTrue($v->none(new PT(self::$schema->searchOrderValue)), $k);
$this->assertTrue($v->none(new PT(self::$schema->searchFts)), $k);
$this->assertTrue($v->none(new PT(self::$schema->searchFtsProperty)), $k);
$this->assertTrue($v->none(new PT(self::$schema->searchFtsQuery)), $k);
$this->assertTrue($v->none(new PT(self::$schema->searchMatch)), $k);
$this->assertTrue($v->none(new PT(self::$schema->searchOrder)), $k);
$this->assertTrue($v->none(new PT(self::$schema->searchOrderValue)), $k);
$this->assertTrue($v->none(new PT(self::$schema->searchFts)), $k);
$this->assertTrue($v->none(new PT(self::$schema->searchFtsProperty)), $k);
$this->assertTrue($v->none(new PT(self::$schema->searchFtsQuery)), $k);
}
}

public function testSearchByIdNotFound(): void {
Expand Down

0 comments on commit b4d8d49

Please sign in to comment.