Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SPARQLQuery strategies for SPARQLWrapper and httpx #169

Closed
lu-pl opened this issue Dec 11, 2024 · 0 comments · Fixed by #167
Closed

Implement SPARQLQuery strategies for SPARQLWrapper and httpx #169

lu-pl opened this issue Dec 11, 2024 · 0 comments · Fixed by #167
Assignees
Labels
refactor Implementation changes that preserve external interfaces and the behavior of the software.

Comments

@lu-pl
Copy link
Contributor

lu-pl commented Dec 11, 2024

Code responsible for SPARQL query execution can be implemented as pluggable strategies with different query execution backends.

E.g. one could come up with a SPARQLWrapperStrategy and an HttpxStrategy as arguments for SPARQLModelAdapter to determine the query backend to use for RDFProxy.

This change is intended to be more of a gentle transition to httpx.

@lu-pl lu-pl self-assigned this Dec 11, 2024
@lu-pl lu-pl added the refactor Implementation changes that preserve external interfaces and the behavior of the software. label Dec 11, 2024
lu-pl added a commit that referenced this issue Dec 11, 2024
Currently, rdfproxy relies on SPARQLWrapper for querying triplestores;
this is not always ideal since SPARQLWrapper occasionally gets
blacklisted e.g. by wikidata and caused severe performance issues in
the past.

The change introduces SPARQLQuery strategies for better control over
what query functionality should run in RDFProxy. The default strategy,
SPARQLWrapperStrategy, implements exactly the previous SPARQLWrapper behavior.
An HttpxStrategy implements the query functionality required by
RDFProxy using raw httpx instead of SPARQLWrapper.

Closes #169.
lu-pl added a commit that referenced this issue Dec 11, 2024
Currently, rdfproxy relies on SPARQLWrapper for querying triplestores;
this is not ideal since SPARQLWrapper occasionally gets
blacklisted e.g. by wikidata and caused severe performance issues in
the past.

The change introduces SPARQLQuery strategies for better control over
what SPARQL query backend should run in RDFProxy. The
SPARQLWrapperStrategy, implements exactly the previous SPARQLWrapper behavior.
An HttpxStrategy (default) implements the query functionality required by
RDFProxy using raw httpx instead of SPARQLWrapper.

Closes #169.
lu-pl added a commit that referenced this issue Dec 11, 2024
Currently, rdfproxy relies on SPARQLWrapper for querying triplestores;
this is not ideal since SPARQLWrapper occasionally gets
blacklisted e.g. by wikidata and caused severe performance issues in
the past.

The change introduces SPARQLQuery strategies for better control over
what SPARQL query backend should run in RDFProxy. The
SPARQLWrapperStrategy, implements exactly the previous SPARQLWrapper behavior.
An HttpxStrategy (default) implements the query functionality required by
RDFProxy using raw httpx instead of SPARQLWrapper.

Closes #169.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Implementation changes that preserve external interfaces and the behavior of the software.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant