fix: resolve group_by config values for SPARQL binding aliases #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, query constructors naively inject the 'group_by' value from the model_config into SPARQL queries. This works until a field name does not correspond to a SPARQL binding name, i.e. until rdfproxy.SPARQLBinding aliases are used. So, field-based grouping obviously requires 'group_by' values to resolve SPARQL binding aliases - which this change implements. Note: The change introduces duplication for resolving SPARQL binding aliases. The planned QueryConstructor class (issue #134) will get rid of this and other design flaws. Fixes #161
The change adapts/adds tests for group_by configs that require rdfproxy.SPARQLBinding resolution.
lu-pl
force-pushed
the
lupl/fix-group-by-binding
branch
from
1a1a649 to
3b9fee7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #161