Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the Github Container Registry already supported? #57

Closed
dersmon opened this issue Dec 8, 2022 · 2 comments
Closed

Is the Github Container Registry already supported? #57

dersmon opened this issue Dec 8, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@dersmon
Copy link

dersmon commented Dec 8, 2022

The main README does not mention the registry. And when trying to pull and run the latest image I get the following error:

vocabs-editor         | Traceback (most recent call last):
vocabs-editor         |   File "manage.py", line 22, in <module>
vocabs-editor         |     execute_from_command_line(sys.argv)
vocabs-editor         |   File "/usr/local/lib/python3.8/site-packages/django/core/management/__init__.py", line 446, in execute_from_command_line
vocabs-editor         |     utility.execute()
vocabs-editor         |   File "/usr/local/lib/python3.8/site-packages/django/core/management/__init__.py", line 420, in execute
vocabs-editor         |     django.setup()
vocabs-editor         |   File "/usr/local/lib/python3.8/site-packages/django/__init__.py", line 24, in setup
vocabs-editor         |     apps.populate(settings.INSTALLED_APPS)
vocabs-editor         |   File "/usr/local/lib/python3.8/site-packages/django/apps/registry.py", line 91, in populate
vocabs-editor         |     app_config = AppConfig.create(entry)
vocabs-editor         |   File "/usr/local/lib/python3.8/site-packages/django/apps/config.py", line 228, in create
vocabs-editor         |     import_module(entry)
vocabs-editor         |   File "/usr/local/lib/python3.8/importlib/__init__.py", line 127, in import_module
vocabs-editor         |     return _bootstrap._gcd_import(name[level:], package, level)
vocabs-editor         |   File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
vocabs-editor         |   File "<frozen importlib._bootstrap>", line 991, in _find_and_load
vocabs-editor         |   File "<frozen importlib._bootstrap>", line 973, in _find_and_load_unlocked
vocabs-editor         | ModuleNotFoundError: No module named 'django_extensions'
@csae8092
Copy link
Member

csae8092 commented Dec 8, 2022

Thanks for pointing this out. I'll into this next week

@csae8092 csae8092 self-assigned this Dec 8, 2022
@csae8092 csae8092 added the bug Something isn't working label Dec 8, 2022
csae8092 added a commit that referenced this issue Dec 14, 2022
* also added another example .env file
@csae8092
Copy link
Member

I guess the error is related with running the application in DEBUG mode, see https://github.com/acdh-oeaw/vocabseditor/blob/master/vocabseditor/settings.py#L67

I'll add django_extensions to the requirements.txt (also used by docker) so this shouldn't be an issue any more

csae8092 added a commit that referenced this issue Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants