-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Conversation
@acdlite question regarding the travis config, isn't a The tests are just fine when running on my local machine. |
@rafaelkallis I guess it's because observable directory is not capitalized in this package. |
Thank you. |
Codecov Report
@@ Coverage Diff @@
## master #422 +/- ##
======================================
Coverage 88.8% 88.8%
======================================
Files 51 51
Lines 375 375
======================================
Hits 333 333
Misses 42 42
Continue to review full report at Codecov.
|
@TrySound thanks for the tip, seems to work now. @istarkov thanks for the feedback. The uselessness of only importing |
I think that change of documentation is ok, |
In that case, I think we should create a dedicated page for them. |
@istarkov sounds reasonable to me, PR can be closed in that case. |
Currently, the rxjs config of recompose, for the
mapStreamToProps
andcomponentFromStream
enhancers, imports the whole rxjs library. This is quite bad for size-sensitive builds.As described here, it is possible to selectively import the features we need from rxjs in order to reduce the build size.
In this PR, I have changed the rxjs 5 config such that only necessary features get imported, dramatically decreasing build size for apps using the enhancers mentioned above with rxjs 5.
In my current app, I have reduced the production build size by 100KB with this change.