This repository has been archived by the owner on Sep 10, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need some discussion before merging:
There were
rxjs4ObservableConfig.js
andrxjsObservableConfig.js
(for rxjs 5) before. This PR upgraderxjsObservableConfig.js
directly to adopt rxjs 6, but it's a breaking change. We might want to create separate files for both rxjs 5 and rxjs 6.Rxjs used to polyfill
Symbol.observable
, but it has been removed since feat(Symbol.observable): is no longer polyfilled ReactiveX/rxjs#3387. We might need to add a notice about polyfillSymbol.observable
to the doc.