Skip to content
This repository has been archived by the owner on Sep 10, 2022. It is now read-only.

React.createFactory is deprecated #795

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .size-snapshot.json
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
{
"lib/packages/recompose/dist/Recompose.umd.js": {
"bundled": 46425,
"minified": 16484,
"gzipped": 4625
"bundled": 46431,
"minified": 16297,
"gzipped": 4640
},
"lib/packages/recompose/dist/Recompose.min.js": {
"bundled": 42863,
"minified": 15204,
"gzipped": 4194
"bundled": 42869,
"minified": 15017,
"gzipped": 4198
},
"lib/packages/recompose/dist/Recompose.esm.js": {
"bundled": 32428,
"minified": 15083,
"gzipped": 3550,
"bundled": 32509,
"minified": 15130,
"gzipped": 3560,
"treeshaked": {
"rollup": {
"code": 310,
Expand Down
3 changes: 2 additions & 1 deletion src/packages/recompose/__tests__/hoistStatics-test.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import React, { createFactory } from 'react'
import React from 'react'
import { mount } from 'enzyme'
import sinon from 'sinon'
import createFactory from '../utils/createFactory'
import { hoistStatics, mapProps } from '../'

test('copies non-React static properties from base component to new component', () => {
Expand Down
2 changes: 1 addition & 1 deletion src/packages/recompose/branch.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { createFactory } from 'react'
import createFactory from './utils/createFactory'
import setDisplayName from './setDisplayName'
import wrapDisplayName from './wrapDisplayName'

Expand Down
2 changes: 1 addition & 1 deletion src/packages/recompose/defaultProps.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { createFactory } from 'react'
import createFactory from './utils/createFactory'
import setDisplayName from './setDisplayName'
import wrapDisplayName from './wrapDisplayName'

Expand Down
2 changes: 1 addition & 1 deletion src/packages/recompose/flattenProp.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { createFactory } from 'react'
import createFactory from './utils/createFactory'
import setDisplayName from './setDisplayName'
import wrapDisplayName from './wrapDisplayName'

Expand Down
6 changes: 3 additions & 3 deletions src/packages/recompose/fromRenderProps.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react'
import createFactory from './utils/createFactory'
import setDisplayName from './setDisplayName'
import wrapDisplayName from './wrapDisplayName'

Expand All @@ -7,8 +7,8 @@ const fromRenderProps = (
propsMapper,
renderPropName = 'children'
) => BaseComponent => {
const baseFactory = React.createFactory(BaseComponent)
const renderPropsFactory = React.createFactory(RenderPropsComponent)
const baseFactory = createFactory(BaseComponent)
const renderPropsFactory = createFactory(RenderPropsComponent)

const FromRenderProps = ownerProps =>
renderPropsFactory({
Expand Down
2 changes: 1 addition & 1 deletion src/packages/recompose/getContext.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { createFactory } from 'react'
import createFactory from './utils/createFactory'
import setDisplayName from './setDisplayName'
import wrapDisplayName from './wrapDisplayName'

Expand Down
3 changes: 2 additions & 1 deletion src/packages/recompose/lifecycle.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/* eslint-disable no-console */
import { createFactory, Component } from 'react'
import { Component } from 'react'
import createFactory from './utils/createFactory'
import setDisplayName from './setDisplayName'
import wrapDisplayName from './wrapDisplayName'

Expand Down
2 changes: 1 addition & 1 deletion src/packages/recompose/mapProps.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { createFactory } from 'react'
import createFactory from './utils/createFactory'
import setDisplayName from './setDisplayName'
import wrapDisplayName from './wrapDisplayName'

Expand Down
2 changes: 1 addition & 1 deletion src/packages/recompose/mapPropsStream.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { createFactory } from 'react'
import $$observable from 'symbol-observable'
import createFactory from './utils/createFactory'
import { componentFromStreamWithConfig } from './componentFromStream'
import setDisplayName from './setDisplayName'
import wrapDisplayName from './wrapDisplayName'
Expand Down
2 changes: 1 addition & 1 deletion src/packages/recompose/nest.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { createFactory } from 'react'
import createFactory from './utils/createFactory'
import getDisplayName from './getDisplayName'

const nest = (...Components) => {
Expand Down
2 changes: 1 addition & 1 deletion src/packages/recompose/renderComponent.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { createFactory } from 'react'
import createFactory from './utils/createFactory'
import wrapDisplayName from './wrapDisplayName'

const renderComponent = Component => _ => {
Expand Down
3 changes: 2 additions & 1 deletion src/packages/recompose/shouldUpdate.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { createFactory, Component } from 'react'
import { Component } from 'react'
import createFactory from './utils/createFactory'
import setDisplayName from './setDisplayName'
import wrapDisplayName from './wrapDisplayName'

Expand Down
5 changes: 5 additions & 0 deletions src/packages/recompose/utils/createFactory.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import { createElement } from 'react'

const createFactory = Type => createElement.bind(null, Type)

export default createFactory
3 changes: 2 additions & 1 deletion src/packages/recompose/withContext.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { createFactory, Component } from 'react'
import { Component } from 'react'
import createFactory from './utils/createFactory'
import setDisplayName from './setDisplayName'
import wrapDisplayName from './wrapDisplayName'

Expand Down
3 changes: 2 additions & 1 deletion src/packages/recompose/withHandlers.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/* eslint-disable no-console */
import { createFactory, Component } from 'react'
import { Component } from 'react'
import createFactory from './utils/createFactory'
import setDisplayName from './setDisplayName'
import wrapDisplayName from './wrapDisplayName'
import mapValues from './utils/mapValues'
Expand Down
3 changes: 2 additions & 1 deletion src/packages/recompose/withPropsOnChange.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { createFactory, Component } from 'react'
import { Component } from 'react'
import { polyfill } from 'react-lifecycles-compat'
import createFactory from './utils/createFactory'
import pick from './utils/pick'
import shallowEqual from './shallowEqual'
import setDisplayName from './setDisplayName'
Expand Down
3 changes: 2 additions & 1 deletion src/packages/recompose/withReducer.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { createFactory, Component } from 'react'
import { Component } from 'react'
import createFactory from './utils/createFactory'
import setDisplayName from './setDisplayName'
import wrapDisplayName from './wrapDisplayName'

Expand Down
3 changes: 2 additions & 1 deletion src/packages/recompose/withState.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { createFactory, Component } from 'react'
import { Component } from 'react'
import createFactory from './utils/createFactory'
import setDisplayName from './setDisplayName'
import wrapDisplayName from './wrapDisplayName'

Expand Down
3 changes: 2 additions & 1 deletion src/packages/recompose/withStateHandlers.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { createFactory, Component } from 'react'
import { Component } from 'react'
import createFactory from './utils/createFactory'
import setDisplayName from './setDisplayName'
import wrapDisplayName from './wrapDisplayName'
import mapValues from './utils/mapValues'
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6793,7 +6793,7 @@ unset-value@^1.0.0:
has-value "^0.3.1"
isobject "^3.0.0"

upath@^1.0.0, upath@^1.0.5, upath@^1.1.0:
upath@^1.0.0, upath@^1.0.5:
version "1.1.0"
resolved "https://registry.yarnpkg.com/upath/-/upath-1.1.0.tgz#35256597e46a581db4793d0ce47fa9aebfc9fabd"

Expand Down