Improve Docker output paths and non-Docker compatibility#171
Merged
ChuxiJ merged 4 commits intoace-step:mainfrom May 15, 2025
Merged
Improve Docker output paths and non-Docker compatibility#171ChuxiJ merged 4 commits intoace-step:mainfrom
ChuxiJ merged 4 commits intoace-step:mainfrom
Conversation
This was referenced May 14, 2025
ChuxiJ
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces two main improvements:
acestep/ui/components.py:ACE_OUTPUT_DIRenvironment variable.ACE_OUTPUT_DIRis not set (e.g., in non-Docker local development), it defaults to a relative path (./outputs), making outputs appear in a directory relative to where the script is run./app/outputspath and improves usability for local development.docker-compose.yaml):./outputs:/app/outputs,./logs:/app/logs,./checkpoints:/app/checkpoints) instead of Docker-managed named volumes. This makes outputs, logs, and checkpoints directly accessible in the project directory on the host, simplifying data management.ACE_OUTPUT_DIR=/app/outputsenvironment variable to the Docker service. This ensures the application inside the container uses the correct path that aligns with the bind mounts and the updated Python code, directing outputs to the shared host directory.