Skip to content
This repository has been archived by the owner on May 1, 2023. It is now read-only.

IE support #38

Closed
dhilt opened this issue Apr 20, 2019 · 3 comments · Fixed by #56
Closed

IE support #38

dhilt opened this issue Apr 20, 2019 · 3 comments · Fixed by #56

Comments

@dhilt
Copy link

dhilt commented Apr 20, 2019

IE doesn't understand ES6 (const, let and arrow functions are the ES6 things that I see in the package sources) and to provide IE compatibility (curse him) we need to have our vendor bundles in ES5. And it's not easy to transpile a specific library during bundling...

The common way is to have ./dist/compare-strings.js in the npm package repo and an npm build script for ES6 -> ES5 transpilation process. If it's ok, I can provide a PR covering this situation. What do you think?

@ebitauld
Copy link

ebitauld commented Apr 25, 2019

Also get an issue with this library and IE11 for an application developped in Angular 7:
image

kimrutherford added a commit to pombase/website that referenced this issue Jun 8, 2019
The module from NPM has a module.exports that doesn't work on IE:
aceakash/string-similarity#38
@ludo97240
Copy link
Contributor

Replace the index.js file by the one in this archive :

index.zip

Maybe a pull request can be done to fix it definitively

@CMadden8
Copy link

CMadden8 commented Aug 5, 2020

I'm also getting this issue in IE11, it's preventing log in to the application. If the patch could be applied to the module that would really help...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants