This repository has been archived by the owner on May 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 128
IE support #38
Comments
kimrutherford
added a commit
to pombase/website
that referenced
this issue
Jun 8, 2019
The module from NPM has a module.exports that doesn't work on IE: aceakash/string-similarity#38
Replace the index.js file by the one in this archive : Maybe a pull request can be done to fix it definitively |
I'm also getting this issue in IE11, it's preventing log in to the application. If the patch could be applied to the module that would really help... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
IE doesn't understand ES6 (const, let and arrow functions are the ES6 things that I see in the package sources) and to provide IE compatibility (curse him) we need to have our vendor bundles in ES5. And it's not easy to transpile a specific library during bundling...
The common way is to have ./dist/compare-strings.js in the npm package repo and an npm build script for ES6 -> ES5 transpilation process. If it's ok, I can provide a PR covering this situation. What do you think?
The text was updated successfully, but these errors were encountered: