This repository has been archived by the owner on May 1, 2023. It is now read-only.
allow findBestMatch to accept an array of objects #124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case:
Instead of wanting to compare
["foo","bar","baz"]
, it can be useful to pass in an array of objects for which you want to compare one property, i.e.and instruct the function to compare based on the
name
property, but return the whole object in the response.Summary of changes:
findBestMatch
now accepts akey
argument. If this argument is not supplied, current behaviour will be retained (i.e. the array member will be used for comparison and must be a string). If a key is supplied, all members of that array must be objects which containkey
as a property.object[key]
is used for comparison, butobject
is returned in the results.Additional tests added for this functionality