Skip to content

Commit

Permalink
add TODOs for #139, #254, #233, #228, #200, #172, #215
Browse files Browse the repository at this point in the history
  • Loading branch information
breandan committed Nov 14, 2018
1 parent d911528 commit 27f2754
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 1 deletion.
2 changes: 2 additions & 0 deletions src/main/kotlin/org/acejump/config/AceConfig.kt
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ import com.intellij.openapi.options.Configurable

/* Persists the state of the AceJump IDE settings across IDE restarts.
* https://www.jetbrains.org/intellij/sdk/docs/basics/persisting_state_of_components.html
*
* TODO: https://github.com/acejump/AceJump/issues/254
*/

@State(name = "AceConfig", storages = [(Storage("AceJump.xml"))])
Expand Down
1 change: 1 addition & 0 deletions src/main/kotlin/org/acejump/config/AceSettings.kt
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import java.awt.Color
import java.awt.Color.*
import kotlin.reflect.KProperty

// TODO: https://github.com/acejump/AceJump/issues/215
data class AceSettings(var layout: KeyLayout = KeyLayout.QWERTY,
var allowedChars: String = layout.allChars(),
// These must be primitives in order to be serializable
Expand Down
1 change: 1 addition & 0 deletions src/main/kotlin/org/acejump/label/Pattern.kt
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ enum class Pattern(val string: String) {
get() = when (this) {
QWERTY -> "fjghdkslavncmbxzrutyeiwoqp5849673210"
// TODO: Prioritize keys by ease of reach for other keyboards
// TODO: https://github.com/acejump/AceJump/issues/172
WORKMN -> "fjghdkslavncmbxzrutyeiwoqp5849673210"
COLEMK -> "fjghdkslavncmbxzrutyeiwoqp5849673210"
DVORAK -> "fjghdkslavncmbxzrutyeiwoqp5849673210"
Expand Down
1 change: 1 addition & 0 deletions src/main/kotlin/org/acejump/view/Canvas.kt
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ object Canvas : JComponent(), Resettable {

private fun Editor.storeBounds() {
viewBounds = getView()
// TODO: Fix reference, cf. https://github.com/acejump/AceJump/issues/200
this::offsetToLogicalPosition.let {
logger.info("View bounds: $viewBounds (lines " +
"${it(viewBounds.first).line}..${it(viewBounds.last).line})")
Expand Down
3 changes: 3 additions & 0 deletions src/main/kotlin/org/acejump/view/Marker.kt
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,9 @@ class Marker : CustomHighlighterRenderer {
drawString(tag!!.toUpperCase(), tagPosition!!.x, tagPosition.y + fontHeight)
}

// TODO: Fix tag alignment and visibility issues
// https://github.com/acejump/AceJump/issues/233
// https://github.com/acejump/AceJump/issues/228
private fun String.alignTag(canvas: Canvas): Point {
val x = tagPoint.x + fontWidth
// val top = Point(x - fontWidth, y - fontHeight)
Expand Down
2 changes: 1 addition & 1 deletion src/main/kotlin/org/acejump/view/Model.kt
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import java.awt.Font.BOLD
/**
* Data holder for all settings and IDE components needed by AceJump.
*
* TODO: Integrate this class with AceSettings.
* TODO: Integrate this class with [org.acejump.config.AceSettings]
*/

object Model {
Expand Down
1 change: 1 addition & 0 deletions src/test/kotlin/AceTest.kt
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import com.intellij.testFramework.EditorActionTestCase
class AceTest : EditorActionTestCase() {
override fun getActionId() = "AceAction"

// TODO: Improve test coverage, https://github.com/acejump/AceJump/issues/139
fun testSomething() {
assert(true)
}
Expand Down

0 comments on commit 27f2754

Please sign in to comment.