Skip to content

Commit

Permalink
[CI] Disable some useless GitHub actions (facebook#14)
Browse files Browse the repository at this point in the history
- Do not run actions on `push` to save resources.
- Skip to run `build-macos-java-static` and
`build-macos-java-static-universal`
jobs because they will cause link errors when OpenSSL introduced and
they are
  not the Pegasus use cases. We can resolve the issue later.
- Fix the error flags used in
`build-linux-encrypted_env-no_compression`.
  • Loading branch information
acelyc111 committed Sep 15, 2023
1 parent 9fd6da7 commit ec8f046
Show file tree
Hide file tree
Showing 10 changed files with 51 additions and 13 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-fuzzers.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: build-fuzzers
on: [push, pull_request]
on: [pull_request]
jobs:
build-fuzzers:
runs-on: ubuntu-latest
Expand Down
44 changes: 41 additions & 3 deletions .github/workflows/jobs-java.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: jobs-java
on: [push, pull_request]
on: [pull_request]
jobs:
build-linux-java:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -77,7 +77,26 @@ jobs:
which java && java -version
which javac && javac -version
- name: Build RocksDBJava x86 and ARM Static Libraries
run: make V=1 J=4 -j4 rocksdbjavastaticosx
run: echo "skip this job, because Pegasus does not use rocksdbjavastaticosx currently"
# TODO(yingchun): resolve it
# build error:
# Undefined symbols for architecture x86_64:
# "_AES_decrypt", referenced from:
# rocksdb::encryption::AESBlockCipher::Decrypt(char*) in encryption.o
# "_AES_encrypt", referenced from:
# rocksdb::encryption::AESCTRCipherStream::EncryptBlock(unsigned long long, char*, char*) in encryption.o
# rocksdb::encryption::AESBlockCipher::Encrypt(char*) in encryption.o
# "_AES_set_decrypt_key", referenced from:
# rocksdb::encryption::AESBlockCipher::InitKey(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in encryption.o
# "_AES_set_encrypt_key", referenced from:
# rocksdb::encryption::AESBlockCipher::InitKey(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in encryption.o
# ld: symbol(s) not found for architecture x86_64
# clang: error: linker command failed with exit code 1 (use -v to see invocation)
# make[2]: *** [rocksdbjavastatic_javalib] Error 1
# make[1]: *** [rocksdbjavastaticosx_arch_x86_64] Error 2
# make: *** [rocksdbjavastaticosx_archs] Error 2
# Error: Process completed with exit code 2.
# run: make V=1 J=4 -j4 rocksdbjavastaticosx
- uses: "./.github/actions/post-steps"
build-macos-java-static-universal:
runs-on: macos-11
Expand All @@ -100,5 +119,24 @@ jobs:
which java && java -version
which javac && javac -version
- name: Build RocksDBJava Universal Binary Static Library
run: make V=1 J=4 -j4 rocksdbjavastaticosx_ub
run: echo "skip this job, because Pegasus does not use rocksdbjavastaticosx_ub currently"
# TODO(yingchun): resolve it
# build error:
# Undefined symbols for architecture x86_64:
# "_AES_decrypt", referenced from:
# rocksdb::encryption::AESBlockCipher::Decrypt(char*) in encryption.o
# "_AES_encrypt", referenced from:
# rocksdb::encryption::AESCTRCipherStream::EncryptBlock(unsigned long long, char*, char*) in encryption.o
# rocksdb::encryption::AESBlockCipher::Encrypt(char*) in encryption.o
# "_AES_set_decrypt_key", referenced from:
# rocksdb::encryption::AESBlockCipher::InitKey(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in encryption.o
# "_AES_set_encrypt_key", referenced from:
# rocksdb::encryption::AESBlockCipher::InitKey(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in encryption.o
# ld: symbol(s) not found for architecture x86_64
# clang: error: linker command failed with exit code 1 (use -v to see invocation)
# make[2]: *** [rocksdbjavastatic_javalib] Error 1
# make[1]: *** [rocksdbjavastaticosx_arch_x86_64] Error 2
# make: *** [rocksdbjavastaticosx_archs] Error 2
# Error: Process completed with exit code 2.
# run: make V=1 J=4 -j4 rocksdbjavastaticosx_ub
- uses: "./.github/actions/post-steps"
2 changes: 1 addition & 1 deletion .github/workflows/jobs-linux-arm.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: jobs-linux-arm
on: [push, pull_request]
on: [pull_request]
jobs:
build-linux-arm:
runs-on: ubuntu-20.04
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/jobs-linux-no-test-run.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: jobs-linux-no-test-run
on: [push, pull_request]
on: [pull_request]
jobs:
build-linux-release:
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/jobs-linux-other-checks.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: jobs-linux-other-checks
on: [push, pull_request]
on: [pull_request]
jobs:
build-linux-clang10-clang-analyze:
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/jobs-linux-run-tests-san.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: jobs-linux-run-tests-san
on: [push, pull_request]
on: [pull_request]
jobs:
build-linux-clang10-asan:
runs-on: ubuntu-latest
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/jobs-linux-run-tests.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: jobs-linux-run-tests
on: [push, pull_request]
on: [pull_request]
jobs:
build-linux:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -85,6 +85,6 @@ jobs:
steps:
- uses: actions/checkout@v3.5.0
- uses: "./.github/actions/pre-steps"
- run: mkdir build && cd build && cmake -DWITH_OPENSSL=0 -DENCRYPTED_ENV=1 -DROCKSDB_DISABLE_SNAPPY=1 -DROCKSDB_DISABLE_ZLIB=1 -DROCKSDB_DISABLE_BZIP=1 -DROCKSDB_DISABLE_LZ4=1 -DROCKSDB_DISABLE_ZSTD=1 .. && make V=1 -j5 && ctest -j5 -V
- run: mkdir build && cd build && cmake -DWITH_SNAPPY=0 -DWITH_ZLIB=0 -DWITH_BZ2=0 -DWITH_LZ4=0 -DWITH_ZSTD=0 .. && make V=1 -j5 && ctest -j5 -V
- run: "cd build/tools && ./sst_dump --help | grep -E -q 'Supported compression types: kNoCompression'"
- uses: "./.github/actions/post-steps"
2 changes: 1 addition & 1 deletion .github/workflows/jobs-macos.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: jobs-macos
on: [push, pull_request]
on: [pull_request]
jobs:
build-macos:
runs-on: macos-11
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/jobs-windows.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: jobs-windows
on: [push, pull_request]
on: [pull_request]
jobs:
build-windows-vs2022:
runs-on: windows-2022
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sanity_check.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Check buck targets and code format
on: [push, pull_request]
on: [pull_request]
permissions:
contents: read

Expand Down

0 comments on commit ec8f046

Please sign in to comment.